fix: Skip hidden fields when navigating#9070
Merged
RoboErikG merged 1 commit intoRaspberryPiFoundation:developfrom May 19, 2025
Merged
fix: Skip hidden fields when navigating#9070RoboErikG merged 1 commit intoRaspberryPiFoundation:developfrom
RoboErikG merged 1 commit intoRaspberryPiFoundation:developfrom
Conversation
gonfunko
approved these changes
May 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes RaspberryPiFoundation/blockly-keyboard-experimentation#524
Proposed Changes
Skip over hidden fields when navigating.
Reason for Changes
We were already skipping hidden inputs, but there are also cases where just a field is hidden and needs to be skipped over.
Test Coverage
Added unit tests for hidden inputs and fields.
Documentation
Additional Information